-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Support for ffmpeg presets #3840
FEAT: Support for ffmpeg presets #3840
Conversation
d8cd331
to
8cba07b
Compare
8cba07b
to
f208345
Compare
f208345
to
6172d66
Compare
✅ Deploy Preview for frigate-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
7d275fb
to
9dd5dd8
Compare
39e03c8
to
87516a3
Compare
Wow. This really looks good. I think you forgot to update this page maybe: https://docs.frigate.video/configuration/index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nitpick. Otherwise looks great.
87516a3
to
a71ef93
Compare
Thank you! I want to leave that page the same, it isn't meant to be copied and it is a good reference for what the default args actually are. |
This looks useful. Will it be possible to define presets in the yaml as well? |
That's a great idea! I'd suggest you open a separate issue/feature request for it. |
Not in this iteration, maybe in the future. |
I just realized that FFmpeg have built-in support for presets, through files: https://ffmpeg.org/ffmpeg.html#Preset-files Perhaps we should have taken that route instead. =/ |
It would be difficult to do the custom fps args for mjpeg and other cases like that |
That's true. :) |
Implementation of #3429
I decided to go with a preset for each ffmpeg arg separately as having a separate
preset
field presented a few problems.specific types of cameras
*rtsp / other protocols
*tcp / udp
*default / with audio
preset
but then also sets other fields as well.To-Do: