Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructured camera specific documentation #4005

Merged
merged 6 commits into from
Oct 8, 2022

Conversation

menkej
Copy link
Contributor

@menkej menkej commented Oct 3, 2022

* Make room for manufacture specific docs
* Added initial (more or less) working setup for Annke C800 camera
docs/docs/configuration/camera_specific.md Outdated Show resolved Hide resolved

### Model/vendor specific setup

#### Annke C800
Copy link
Sponsor Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything specific about the Annke in this case? Seems like these args would be relevant for all H.265 only cameras.

docs/docs/configuration/camera_specific.md Outdated Show resolved Hide resolved
docs/docs/configuration/camera_specific.md Outdated Show resolved Hide resolved
docs/docs/configuration/camera_specific.md Outdated Show resolved Hide resolved
@NickM-27 NickM-27 changed the base branch from dev to master October 3, 2022 21:51
remove tracking settings from example

Co-authored-by: Nicolas Mowen <nickmowen213@gmail.com>
@netlify
Copy link

netlify bot commented Oct 5, 2022

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit 24338cb
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/633dd1094c1452000870fa0c
😎 Deploy Preview https://deploy-preview-4005--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@menkej
Copy link
Contributor Author

menkej commented Oct 5, 2022

Why did you change the branch from dev to master @NickM-27 ? dev is default in this repo. How are you using these branches? Just curious - want to get it right next time. ;-)

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented Oct 5, 2022

@menkej dev is for new features / work that will be going into a future version of frigate. As these are just docs changes and they are relevant to the current version of frigate, it should target master so it will be uploaded to the docs when the PR is merged

* removed doubled headline in advanced options
* changed headline level for camera specific setup to make headlines
  show up in toc
## Model/vendor specific setup

### Annke C800
This camera is H.265 only. To be able to play clips on a Mac the H.265 stream has to be repackaged and the audio stream has to be converted to aac. Unfortunately direct playback of in the browser is not working (yet), but the downloaded clip can be played locally.
Copy link
Sponsor Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This camera is H.265 only. To be able to play clips on a Mac the H.265 stream has to be repackaged and the audio stream has to be converted to aac. Unfortunately direct playback of in the browser is not working (yet), but the downloaded clip can be played locally.
This camera is H.265 only. To be able to play clips on some devices the H.265 stream has to be repackaged and the audio stream has to be converted to aac. Unfortunately direct playback of in the browser is not working (yet), but the downloaded clip can be played locally.

Copy link
Sponsor Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO better to not be specific since it could be other devices as well.

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented Oct 5, 2022

Looks good though, thank you!

@blakeblackshear blakeblackshear merged commit 2eada21 into blakeblackshear:master Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Support]: Add a Wiki with configuration help
3 participants