Support special characters in passwords, redacted logs & debug config #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickM-27
commented
Oct 9, 2022
frigate/const.py
Outdated
| # Regex Consts | ||
|
|
||
| REGEX_CAMERA_NAME = "^[a-zA-Z0-9_-]+$" | ||
| REGEX_CAMERA_USER_PASS = "[a-zA-Z0-9_-]+:[a-zA-Z0-9!$_-]+@" |
There was a problem hiding this comment.
I know we can't have special characters in password right now but figured might as well filter them out in case that changes.
There was a problem hiding this comment.
I'm sure we can fix that too. Might as well look at doing that here. They probably just need to be properly escaped when opening the subprocess.
NickM-27
changed the title
|
This one needs a rebase |
NickM-27
force-pushed
the
redacted-logs
branch
from
d0f85b5
to
9c41ce1
Compare
✅ Deploy Preview for frigate-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
blakeblackshear
approved these changes
Nov 2, 2022
herostrat
pushed a commit
to herostrat/frigate
that referenced
this pull request
Nov 24, 2022
…blakeblackshear#4057) * Consts for regex * Add regex for camera username and password * Redact user:pass from ffmpeg logs * Redact ffmpeg commands * Move common function to util * Add tests * Formatting * Remove unused imports * Fix test * Add port to test * Support special characters in passwords * Add tests for special character handling * Remove docs about not supporting special characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redact user:pass from cameras in logs and ffmpeg commands in debug
Example: