More config checks #4310
Merged
More config checks #4310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frigate-docs canceled.
|
|
Does any of this translate when setting the schema validation in vs code when editing a yaml file? I'm guessing not. Maybe that's not possible. Mostly curious as we plan for an embedded config editor. |
From what I can tell I don't think so unfortunately, doesn't seem there is a way to set errors in there: https://pydantic-docs.helpmanual.io/usage/schema/#schema-customization |
|
O well. We will just have to do what we can client side and have a validate endpoint for the rest. |
blakeblackshear
approved these changes
Nov 9, 2022
herostrat
pushed a commit
to herostrat/frigate
that referenced
this pull request
Nov 24, 2022
* Move existing checks to own functions * Add config check for zone objects that are not tracked * Add tests for config error * Formatting * Catch case where field is defined multiple times and add test * Add warning for rtmp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add config checks:
zone -> objectsthat are not tracked