Revamped debug UI and add camera / process info, ffprobe copying #4349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickM-27
force-pushed
the
revamped-debug
branch
from
8d87b0e
to
360860d
Compare
✅ Deploy Preview for frigate-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
blakeblackshear
requested changes
Nov 10, 2022
NickM-27
force-pushed
the
revamped-debug
branch
from
f07af5a
to
ecfafdc
Compare
blakeblackshear
approved these changes
Nov 13, 2022
herostrat
pushed a commit
to herostrat/frigate
that referenced
this pull request
Nov 24, 2022
…keblackshear#4349) * Move each camera to a separate card and show per process info * Install top * Add support for cpu usage stats * Use cpu usage stats in debug * Increase number of runs to ensure good results * Add ffprobe endpoint * Get ffprobe for multiple inputs * Copy ffprobe in output * Add fps to camera metrics * Fix lint errors * Update stats config * Add ffmpeg pid * Use grid display so more cameras can take less vertical space * Fix hanging characters * Only show the current detector * Fix bad if statement * Return full output of ffprobe process * Return full output of ffprobe process * Don't specify rtsp_transport * Make ffprobe button show dialog with output and option to copy * Adjust ffprobe api to take paths directly * Add docs for ffprobe api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this can stand on its own, #3931 can be rebased on to this and include the GPU information. The GPU PR will also include the ability to copy vainfo output.
This PR revamps the debug screen, adds per process info, and adds an ffprobe button to copy the ffprobe output (including all streams if there are multiple)
Here is a screenshot of the new look:
Here is a video of getting the ffprobe:
Screen.Recording.2022-11-10.at.7.35.51.AM.mov