Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce amount layers of the docker image #4448

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

felipecrs
Copy link
Contributor

This reduces the amount of layers in the image from 13 to 5. Less layers is a recommended practice for Docker images. It should make pulling the image faster, and perhaps speed up the container startup time.

This also reduces the size of the image from 1.53GB to 1.52GB, which isn't noticeable, I know.

It as well makes the build process faster, as it parallelizes several other steps.

As well as some other improvements, like:

  • Add go2rtc and nginx bin folders to PATH
  • Refactor s6-related scripts, so they are more readable
  • Convert long dockerfile RUN instructions to shell scripts, so they are more readable and can be easily linted with shellcheck

@netlify
Copy link

netlify bot commented Nov 20, 2022

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit fd91e71
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/637c222e1c4b800009c84a97

@felipecrs felipecrs marked this pull request as ready for review November 20, 2022 17:37
@blakeblackshear
Copy link
Owner

There are some conflicts from your other PR

@felipecrs
Copy link
Contributor Author

There are some conflicts from your other PR

Thanks. Fixed now.

@blakeblackshear blakeblackshear merged commit f4187d6 into blakeblackshear:dev Nov 22, 2022
herostrat pushed a commit to herostrat/frigate that referenced this pull request Nov 24, 2022
* Reduce amount layers of the docker image

* Fix models file name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants