Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs about additions #4504

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

herostrat
Copy link
Contributor

I don't know if this is useful for others and ok for you blake.
Background: I only recently found out about doubletake and thought to make it easier to find useful additions.

If this should not go in the docs, no harm done, you can just close it.

@netlify
Copy link

netlify bot commented Nov 24, 2022

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit 0b8c7c8
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/638511f7a194320009bb64b9
😎 Deploy Preview https://deploy-preview-4504--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented Nov 24, 2022

Can you point this at master since it's just a docs update?

I think it would be good to mention this, Third Party Integrations might be a better name but I think it makes sense.

@herostrat herostrat force-pushed the nvr_additions branch 2 times, most recently from 0069a11 to fd53492 Compare November 24, 2022 18:07
@herostrat
Copy link
Contributor Author

Sure thing, I will change it to master.

I changed it to "Third Party Extensions" as Integrations is kind of loaded with home-assistant.

@herostrat herostrat changed the base branch from dev to master November 24, 2022 18:08
@herostrat herostrat force-pushed the nvr_additions branch 2 times, most recently from fd7a603 to fe5014b Compare November 24, 2022 18:12
@NickM-27
Copy link
Sponsor Collaborator

Sure thing, I will change it to master.

I changed it to "Third Party Extensions" as Integrations is kind of loaded with home-assistant.

Yeah that's fair, sounds good to me

@blacknell
Copy link
Contributor

Couple of spelling mistakes - being not beiung; an overview of additions

@blacknell
Copy link
Contributor

Couple of spelling mistakes - being not beeing; an overview of additions

@herostrat @NickM-27 - I can't fix these myself as I'm not marked as a repo contributor

@herostrat
Copy link
Contributor Author

Thanks for the review. I will fix them after work today.

@blacknell
Copy link
Contributor

Could I suggest moving the hyperlink to double take from the heading to the body of text. It's more consistent visually and wasn't immediately obvious.

@NickM-27
Copy link
Sponsor Collaborator

@blacknell you should be able to make suggestions / comments directly on the code by opening "view files" and then clicking on a line

@github-actions github-actions bot added the stale label Dec 31, 2022
@github-actions github-actions bot closed this Jan 3, 2023
@NickM-27 NickM-27 reopened this Jan 23, 2023
@github-actions github-actions bot removed the stale label Jan 24, 2023
@github-actions github-actions bot added the stale label Feb 23, 2023
@herostrat
Copy link
Contributor Author

Not stale, but I don't know if it is desired

@github-actions github-actions bot removed the stale label Feb 24, 2023
@blakeblackshear blakeblackshear merged commit a554b22 into blakeblackshear:master Feb 24, 2023
@skrashevich
Copy link
Contributor

skrashevich commented Apr 2, 2023

This project does not seem to be supported anymore. I have an active fork. Maybe it makes sense to replace the link?

madsciencetist pushed a commit to madsciencetist/frigate that referenced this pull request May 10, 2023
* Add docs about additions

* Fix review findings: Spelling

* Add suggestions from PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants