Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not apply -user_agent for rtmp streams #4596

Merged
merged 1 commit into from
Dec 4, 2022
Merged

Do not apply -user_agent for rtmp streams #4596

merged 1 commit into from
Dec 4, 2022

Conversation

felipecrs
Copy link
Contributor

@netlify
Copy link

netlify bot commented Dec 4, 2022 •
edited

✅ Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit e1bad38
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/638cb91e61c72400099df817

@felipecrs felipecrs changed the title Do not apply -user_agent for rtmp streams Do not apply -user_agent for rtmp streams Dec 4, 2022
@felipecrs
Copy link
Contributor Author

felipecrs commented Dec 4, 2022 •
edited

Funny, in this question people are using -user_agent together with RTMP:

https://stackoverflow.com/questions/34525487/set-useragent-in-ffmpeg

Let me just do some investigation first.

@felipecrs
Copy link
Contributor Author

Ok, I could replicate the issue and test by myself. It only errors for RTMP, but not for HTTP or RTSP, therefore I think the PR is correct.

Honestly, I think this is a bug in FFmpeg, but I'm not willing to report it (their bug tracker scared me).

@blakeblackshear blakeblackshear merged commit 87e2810 into blakeblackshear:dev Dec 4, 2022
@felipecrs felipecrs mentioned this pull request Dec 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeblackshear blakeblackshear blakeblackshear approved these changes

@NickM-27 NickM-27 NickM-27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Support]: ERROR : Option user_agent not found.
3 participants
@felipecrs @blakeblackshear @NickM-27