Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config editor to webUI #4608

Merged
merged 14 commits into from
Dec 7, 2022
Merged

Conversation

NickM-27
Copy link
Sponsor Collaborator

@NickM-27 NickM-27 commented Dec 5, 2022

No description provided.

@netlify
Copy link

netlify bot commented Dec 5, 2022

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit 603d1b3
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/638f981c3a1a2e0008af9f4e

@blakeblackshear
Copy link
Owner

I think it's time to consider moving config to its own page now that we have so much info on the System page.

I was thinking it would be a good idea to show the yaml config as the user defined it so we don't get a cluttered JSON config in support issues with all the default values.

It may be easy enough to include an in page config editor that uses the schema validation if there is a library that just works out of the box.

@NickM-27 NickM-27 marked this pull request as draft December 6, 2022 01:28
@NickM-27
Copy link
Sponsor Collaborator Author

NickM-27 commented Dec 6, 2022

I think it's time to consider moving config to its own page now that we have so much info on the System page.

I was thinking it would be a good idea to show the yaml config as the user defined it so we don't get a cluttered JSON config in support issues with all the default values.

It may be easy enough to include an in page config editor that uses the schema validation if there is a library that just works out of the box.

Got it, yeah that would be nice. I think we could definitely have a save button and validate as part of the saving process, not sure about the live validation

@NickM-27 NickM-27 changed the title System screen show and copy debug config in yaml format Add config editor to webUI Dec 6, 2022
@NickM-27 NickM-27 marked this pull request as ready for review December 6, 2022 19:14
@blakeblackshear blakeblackshear merged commit 7888059 into blakeblackshear:dev Dec 7, 2022
@NickM-27 NickM-27 deleted the yaml-debug branch December 9, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants