Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker Compose Installation to Not Mount Config File as Read Only #4871

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

AML225
Copy link
Contributor

@AML225 AML225 commented Jan 3, 2023

Current Docker Compose examples state to mount the configuration file with the read-only flag (:ro). This prevents users from updating configuration using the new v12.0 UI functionality.

Mounting the configuration file with the ":ro" flag will prevent users from editing config in new v12.0 UI.
@netlify
Copy link

netlify bot commented Jan 3, 2023

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit 83aa8b6
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/63b460bee7bcdb0008af0410
😎 Deploy Preview https://deploy-preview-4871--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Sponsor Collaborator

@NickM-27 NickM-27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have it put :rw just so it's clear that this is the default?

@AML225
Copy link
Contributor Author

AML225 commented Jan 3, 2023

Maybe we should have it put :rw just so it's clear that this is the default?

I'm not an expert on Docker volumes/bind-mounts, however the examples on https://docs.docker.com/storage/volumes/ and https://docs.docker.com/storage/bind-mounts/ seem to specify ":ro" when enforcing read-only, but don't specify anything when read-write. By default bind-mounts are read-write assuming there are no issues with user permissions (PUID/PGID).

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented Jan 3, 2023

Right, I was just suggesting that it would be more clear to frigate users that the config is read/write by default now. Then again if the user doesn't know the default the rw likely won't mean anything either so it's probably fine to leave it that way.

@blakeblackshear blakeblackshear merged commit 417a42b into blakeblackshear:dev Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants