-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YOLOX support for OpenVINO Detector #5285
YOLOX support for OpenVINO Detector #5285
Conversation
✅ Deploy Preview for frigate-docs canceled.
|
@NateMeyer FYI |
I'll take a closer look and try to run this later today. Do you have any insight on the differences between this and the yolov4 models? |
I believe YOLOx is anchorless, while most other YOLO variants have anchors. Post processing the tensors would require a little more math due to anchors. What I have here for YOLOx should be 90% of the way there to support other YOLO variants as well. So maybe in the future, that could be explored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played with this a bit today and it seems to run pretty well. In general the code looks pretty good to me.
@NateMeyer @NickM-27 are there any opens on this before it can be merged? |
First need to get checks passing |
Alright 3rd time's the charm. If you can kick off the checks, it would be great. |
All green! |
@NateMeyer @NickM-27 let me know if there are any other opens preventing this merge. Thanks. |
This PR is to add YOLOX support for the newly added OpenVINO detector. I added a new config parameter called model_type, which is
ssd
by default to match the defaultssdlite_mobilenet_v2
model that comes with Frigate. Users can change this toyolox
to use ayolox
model instead. After the changes, I confirmed that the existing SSD OpenVINO support still works.I have also added a text into the documents explaining how to use a yolox model, and what the limitations are.