Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YOLOX support for OpenVINO Detector #5285

Merged
merged 9 commits into from
Feb 4, 2023

Conversation

aeozyalcin
Copy link
Contributor

This PR is to add YOLOX support for the newly added OpenVINO detector. I added a new config parameter called model_type, which is ssd by default to match the default ssdlite_mobilenet_v2 model that comes with Frigate. Users can change this to yolox to use a yolox model instead. After the changes, I confirmed that the existing SSD OpenVINO support still works.

I have also added a text into the documents explaining how to use a yolox model, and what the limitations are.

@netlify
Copy link

netlify bot commented Jan 29, 2023

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit cf70808
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/63db2c1af4ea67000823a26b

@aeozyalcin
Copy link
Contributor Author

@NateMeyer FYI

@NateMeyer
Copy link
Contributor

I'll take a closer look and try to run this later today. Do you have any insight on the differences between this and the yolov4 models?

@aeozyalcin
Copy link
Contributor Author

I'll take a closer look and try to run this later today. Do you have any insight on the differences between this and the yolov4 models?

I believe YOLOx is anchorless, while most other YOLO variants have anchors. Post processing the tensors would require a little more math due to anchors. What I have here for YOLOx should be 90% of the way there to support other YOLO variants as well. So maybe in the future, that could be explored.

Copy link
Contributor

@NateMeyer NateMeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played with this a bit today and it seems to run pretty well. In general the code looks pretty good to me.

docs/docs/configuration/detectors.md Outdated Show resolved Hide resolved
frigate/detectors/plugins/openvino.py Outdated Show resolved Hide resolved
frigate/detectors/plugins/openvino.py Show resolved Hide resolved
@aeozyalcin
Copy link
Contributor Author

@NateMeyer @NickM-27 are there any opens on this before it can be merged?

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented Feb 1, 2023

@NateMeyer @NickM-27 are there any opens on this before it can be merged?

First need to get checks passing

@aeozyalcin
Copy link
Contributor Author

Alright 3rd time's the charm. If you can kick off the checks, it would be great.

@aeozyalcin
Copy link
Contributor Author

All green!

@aeozyalcin
Copy link
Contributor Author

@NateMeyer @NickM-27 let me know if there are any other opens preventing this merge. Thanks.

@blakeblackshear blakeblackshear merged commit b330942 into blakeblackshear:dev Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants