Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return sub_labels in event summary information #5642

Merged
merged 1 commit into from
Mar 5, 2023

Conversation

dermotduffy
Copy link
Contributor

@netlify
Copy link

netlify bot commented Mar 5, 2023

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit c7c5cf6
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/64041601e8bef10008ccdf77

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented Mar 5, 2023

Just want to make sure you're aware, there are cases where a sub_label can be a comma separated list of multiple names (for example if two people walk up to the camera at the same time). So the card may want to split that list up depending on how the search is being done.

@dermotduffy
Copy link
Contributor Author

Just want to make sure you're aware, there are cases where a sub_label can be a comma separated list of multiple names (for example if two people walk up to the camera at the same time). So the card may want to split that list up depending on how the search is being done.

Did not know that -- thanks, will split on the card.

@dermotduffy
Copy link
Contributor Author

Actually -- that's kind of a problem. If the sub label is foo,bar, and the card wants to search for bar, there's not a great way to do that except separately getting the list of all sub_labels and reverse matching the "unsplit" labels.

Is there a reason sub_label isn't just a list, like zones?

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented Mar 5, 2023

Actually -- that's kind of a problem. If the sub label is foo,bar, and the card wants to search for bar, there's not a great way to do that except separately getting the list of all sub_labels and reverse matching the "unsplit" labels.

You can see how I handled this here: #5602

Ended up not being too bad

Is there a reason sub_label isn't just a list, like zones?

It was just a string, wasn't until other projects started adding support for the feature directly (like doubletake) that it became a concern.

Anyway, let me know if a solution like my PR isn't possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should sub_labels be included in api/events/summary ?
3 participants