-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed extension of config file #5803
Fixed extension of config file #5803
Conversation
Using frigate.yml as the config file for the HA addon gives a validation error, the same contents in frigate.yaml work.
✅ Deploy Preview for frigate-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This is incorrect, frigate.yml has worked for many users for a long time (it was only a few versions ago that the .yaml was added) Also the log you have shows an error in the contents itself which would have nothing to do with the file extension since frigate loads both file extensions exactly the same way |
On closer inspection you're right: I created frigate.yaml on autopilot because it was in the HA config dir, then realised the docs were asking for frigate.yml, created that too and tried to populate it without deleting frigate.yaml. So a more accurate summary of the problem would be: this application will accept two different filenames for the same config file and silently override a populated file with a 0 length one. |
Not 100% sure what you mean by override? Frigate does not write / edit the config file |
It ignores a populated frigate.yml when an empty frigate.yaml also exists. |
I mean, it has no relevance if it's empty or not. Just prefers .yaml Lines 73 to 81 in 3f17f87
|
It prefers .yaml silently then logs a config error that doesn't list the filename throwing it. I'm sure that may seem like a non-issue to someone who maintains an app and is intimately familiar with it, but it can eat hours for someone who's completely unfamiliar with it and installing it for the first time. |
I can see why you may have that perspective, but I spend time every day helping users in the issues with first time configuration, hardware, cameras, etc. so I have quite a bit of context for what new users experience and that is very important given the vast difference in perspective between a new user and someone who helps maintain the project. It's important to make the docs cover potential issues without being confusing to users who may not understand what the docs are trying to say. Feel free to update this PR to communicate this behavior for the addon otherwise we can close this PR and create an issue |
Co-authored-by: Nicolas Mowen <nickmowen213@gmail.com>
Using frigate.yml as the config file for the HA addon gives a validation error, the same contents in frigate.yaml work.