Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override go2rtc binary in add-on #5876

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

felipecrs
Copy link
Contributor

This adds a feature from the go2rtc add-on to the Frigate add-on:

This is motived by this comment:

Which says that users can override go2rtc through bind mounts, but that's unfortunately not available to add-on users like me.

I'm happy to make changes if needed.

@netlify
Copy link

netlify bot commented Mar 29, 2023

👷 Deploy Preview for frigate-docs processing.

Name Link
🔨 Latest commit 03e0570
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/642472f243bbe5000893821e

@netlify
Copy link

netlify bot commented Mar 29, 2023

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit 03e0570
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/642472f243bbe5000893821e

@NickM-27
Copy link
Sponsor Collaborator

I think we may run into a problem with users who are also running the webrtc card v3 and have not pointed it at frigate. Depends how that version of go2rtc binary gets named

@felipecrs
Copy link
Contributor Author

felipecrs commented Mar 29, 2023

Some alternative ideas then:

  1. /config/frigate-go2rtc
  2. /config/frigate/go2rtc
  3. /config/frigate/bin/go2rtc

WDYT?

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented Mar 29, 2023

Looks like go2rtc may be fine, looks like the webrtc card includes the arch / version in the name.

https://github.com/AlexxIT/WebRTC/blob/7bddb2dfaa84c8b6c38af62bed419252a1c26829/custom_components/webrtc/utils.py#L29

@NickM-27
Copy link
Sponsor Collaborator

Just tested, works fine for me in a docker container as well which makes it easier

@blakeblackshear blakeblackshear merged commit 1b8cd10 into blakeblackshear:dev Mar 30, 2023
@cvroque
Copy link

cvroque commented Apr 6, 2023

Sorry to post on a closed PR, but how do I override the embedded go2rtc version while using the add-on?

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented Apr 6, 2023

Sorry to post on a closed PR, but how do I override the embedded go2rtc version while using the add-on?

Place the go2rtc file called go2rtc in /config

@felipecrs
Copy link
Contributor Author

And ensure it has execution permission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants