Improve documentation on web rtc #6005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frigate-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
NickM-27
requested changes
Apr 13, 2023
docs/docs/configuration/live.md
Outdated
| services: | ||
| frigate: | ||
| ports: | ||
| - "8555:8555" |
There was a problem hiding this comment.
We should probably match the config in the main docker getting started docs and suggest mapping 8555 tcp and 8555 udp
There was a problem hiding this comment.
Great suggestions! Thank you for reviewing.
There was a problem hiding this comment.
Unless you are referring to a different file, it looks like that change was already implemented (by you):
Did you have some other place in mind to update?
There was a problem hiding this comment.
Sorry, what I meant was you should take the way it is shown there (where it maps tcp and udp) and apply that to your changes in live.md
Co-authored-by: Nicolas Mowen <nickmowen213@gmail.com>
NickM-27
previously approved these changes
Apr 14, 2023
NickM-27
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves some documentation on getting web rtc working, especially when running frigate on different host machine. Please let me know if you have any further improvements or suggestions.