Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation.md #6128

Merged
merged 13 commits into from
Apr 17, 2023
Merged

Update installation.md #6128

merged 13 commits into from
Apr 17, 2023

Conversation

imne
Copy link
Contributor

@imne imne commented Apr 17, 2023

added instructions to run frigate on a synology NAS running DSM 7

instruction work 100% please see below proof of testing:
image

@netlify
Copy link

netlify bot commented Apr 17, 2023

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit 6ee6298
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/643db7ae6caaf500083aad86
😎 Deploy Preview https://deploy-preview-6128--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

docs/docs/frigate/installation.md Outdated Show resolved Hide resolved
docs/docs/frigate/installation.md Outdated Show resolved Hide resolved
imne and others added 2 commits April 17, 2023 20:35
Co-authored-by: Nicolas Mowen <nickmowen213@gmail.com>
addressed comment
@imne imne requested a review from NickM-27 April 17, 2023 18:43
Copy link
Sponsor Collaborator

@NickM-27 NickM-27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a few issues with the images:

  • we will want the image to show the default ports mapped to their default ports, it would cause confusion
  • the config should not be read only since 0.12 allows for editing the config file inside the container
  • I'd personally like to see some explanation of the settings above each image

Copy link
Sponsor Collaborator

@NickM-27 NickM-27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a few issues with the images:

  • we will want the image to show the default ports mapped to their default ports, it would cause confusion
  • the config should not be read only since 0.12 allows for editing the config file inside the container
  • I'd personally like to see some explanation of the settings above each image

@imne imne requested a review from NickM-27 April 17, 2023 19:20
@imne
Copy link
Contributor Author

imne commented Apr 17, 2023

I see a few issues with the images:

* we will want the image to show the default ports mapped to their default ports, it would cause confusion

* the config should not be read only since 0.12 allows for editing the config file inside the container

* I'd personally like to see some explanation of the settings above each image

addressed

docs/docs/frigate/installation.md Outdated Show resolved Hide resolved
docs/docs/frigate/installation.md Outdated Show resolved Hide resolved
docs/docs/frigate/installation.md Outdated Show resolved Hide resolved
docs/docs/frigate/installation.md Outdated Show resolved Hide resolved
docs/docs/frigate/installation.md Outdated Show resolved Hide resolved
imne and others added 4 commits April 17, 2023 21:29
Co-authored-by: Nicolas Mowen <nickmowen213@gmail.com>
Co-authored-by: Nicolas Mowen <nickmowen213@gmail.com>
Co-authored-by: Nicolas Mowen <nickmowen213@gmail.com>
Co-authored-by: Nicolas Mowen <nickmowen213@gmail.com>
@imne imne requested a review from NickM-27 April 17, 2023 19:33
NickM-27
NickM-27 previously approved these changes Apr 17, 2023
@imne
Copy link
Contributor Author

imne commented Apr 17, 2023

@NickM-27 @blakeblackshear anything else I need to do on my end to get the changes merged into master?

@NickM-27
Copy link
Sponsor Collaborator

Wait for Blake to review, it will either be merged or some changes requested

Copy link
Owner

@blakeblackshear blakeblackshear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for contributing.

@blakeblackshear blakeblackshear merged commit c820bad into blakeblackshear:master Apr 17, 2023
10 checks passed
@imne imne deleted the patch-1 branch April 17, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants