-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installation.md #6128
Update installation.md #6128
Conversation
✅ Deploy Preview for frigate-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Co-authored-by: Nicolas Mowen <nickmowen213@gmail.com>
addressed comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a few issues with the images:
- we will want the image to show the default ports mapped to their default ports, it would cause confusion
- the config should not be read only since 0.12 allows for editing the config file inside the container
- I'd personally like to see some explanation of the settings above each image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a few issues with the images:
- we will want the image to show the default ports mapped to their default ports, it would cause confusion
- the config should not be read only since 0.12 allows for editing the config file inside the container
- I'd personally like to see some explanation of the settings above each image
updated documentation as per comment
formatting
addressed |
Co-authored-by: Nicolas Mowen <nickmowen213@gmail.com>
Co-authored-by: Nicolas Mowen <nickmowen213@gmail.com>
Co-authored-by: Nicolas Mowen <nickmowen213@gmail.com>
Co-authored-by: Nicolas Mowen <nickmowen213@gmail.com>
@NickM-27 @blakeblackshear anything else I need to do on my end to get the changes merged into master? |
Wait for Blake to review, it will either be merged or some changes requested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for contributing.
added instructions to run frigate on a synology NAS running DSM 7
instruction work 100% please see below proof of testing: