Replace subprocess usage with os module for better performance and maintainability #6298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o interact with the filesystem directly
✅ Deploy Preview for frigate-docs canceled.
|
NickM-27
approved these changes
Apr 27, 2023
skrashevich
force-pushed
the
patch-230428
branch
3 times, most recently
from
cc81f9a
to
7c8af6a
Compare
skrashevich
force-pushed
the
patch-230428
branch
from
7c8af6a
to
1ff72b8
Compare
|
Fixed non-obvious calculation problems on some systems |
|
Need to fix conflicts dev now that the go2rtc and record process were added to system page |
NickM-27
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the frigate/util.py and frigate/record/cleanup.py files to replace the usage of subprocess with Python's built-in os module for interacting with the filesystem. This change improves performance by avoiding the overhead of spawning new processes and simplifies the codebase by using native Python functions. Additionally, this update provides better error handling and maintainability.