-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support separate WebUI user / view modes #6916
Conversation
- fix AppBar render order, its tooltips are visible now
✅ Deploy Preview for frigate-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lint complains about maybe this whole thing is coded wrong, i haven't a clue, react is a wonder to behold... |
I think this is better presented as |
that would imply more than simple on/off. Could be user/advanced/admin/debug etc. |
some wip on many options: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, I think that's what Blake had in mind and it's great how easily it can be expanded to other things in the future
de9981f
to
60393d7
Compare
I prefer the former, makes it much more obvious which is the currently selected mode and takes up less space |
the event thumbnail renders over AppBar in events page... tried a bunch of things, counlt work around it... with this revert, the "More Options" tooltip for AppBar menu is broken again
- view mode will default to admin if config does fail to load for w/e reason - rename viewMode to currentViewMode
… advancedoptionsui
Dropdown inside a menu is not ideal though. A separate icon button for "user pref" might be better. Profile icon in header expands to the view modes. |
Thank you for your pull request, we are currently rewriting the UI for the next version of frigate and this PR can't be merged. This functionality is being considered for the new UI. |
looks like this:
https://github.com/blakeblackshear/frigate/assets/57186372/46937caa-a7a9-4661-a6d7-4dd427295787
default behavior can be set like