Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pre capture for custom events #7038

Merged
merged 2 commits into from Jul 6, 2023
Merged

Conversation

NickM-27
Copy link
Sponsor Collaborator

@NickM-27 NickM-27 commented Jul 5, 2023

No description provided.

@netlify
Copy link

netlify bot commented Jul 5, 2023

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit ec916f0
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/64a56795129112000827d93a

@kdill00
Copy link

kdill00 commented Jul 5, 2023

Curious, does it still need record set to all to capture stuff if there is not detected object or motion in the allotted period? Or is that what this is correcting? Or is that expected? I have no real preference just curious as it took me a second to figure out why sometimes my created events wouldn’t record because I’m dumb like that

@NickM-27
Copy link
Sponsor Collaborator Author

NickM-27 commented Jul 5, 2023

Curious, does it still need record set to all to capture stuff if there is not detected object or motion in the allotted period? Or is that what this is correcting? Or is that expected? I have no real preference just curious as it took me a second to figure out why sometimes my created events wouldn’t record because I’m dumb like that

Currently for audio recordings it MUST match the recording retention, meaning for any of the audio detection to be saved you either need all mode or you need motion and motion had to occur.

We are planning to make audio be treated like motion so if any audio events are detected that will be kept the same as motion. This would fix the main problem but the same (intended) behavior still applies that pre_capture and post_capture will only keep the segment if that previous / next segment also meet the configured recording retention

@blakeblackshear blakeblackshear merged commit 0f68fbc into dev Jul 6, 2023
11 checks passed
@blakeblackshear blakeblackshear deleted the custom-event-pre-capture branch July 6, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants