Community Supported Boards Framework

[NickM-27]

No description provided.

[netlify]

✅ Deploy Preview for frigate-docs canceled.

Name	Link
🔨 Latest commit	a20eb5b
🔍 Latest deploy log	https://app.netlify.com/sites/frigate-docs/deploys/64bd6dc57cba3200087b9b29

[skrashevich]

Maybe it makes sense if the base branch is running on a platform for which there is a Community build - show a notification in the webUI about it?

[NickM-27]

I think it would be difficult to know for sure what the current platform is given that frigate runs in docker.

[skrashevich]

/proc and /sys pseudo-filesystems available in docker. For example, rPi detect is very simple:

# cat /proc/cpuinfo | tail -1
Model		: Raspberry Pi 4 Model B Rev 1.4

[NickM-27]

I see, could make sense although frigate doesn't really have a notifications system right now.

Either way, that is outside the scope of this PR 👍

[NateMeyer]

Is the intent to just have "local" targets for community-supported builds, or can there be tagged, cross-compileable make targets too?

[NickM-27]

Is the intent to just have "local" targets for community-supported builds, or can there be tagged, cross-compileable make targets too?

I just forgot to add that to the Makefile 👍

[NateMeyer]

I'd like to propose making the makefile a bit more dynamic with community builds. I think we should move the rpi targets to their own file inside the docker/build/rpi folder. This rpi.mk file would look something like this:

BOARDS += rpi

local-rpi: version local
	docker buildx build --tag frigate:latest-rpi --build-arg BASE_IMAGE=frigate:latest --load --file docker/build/rpi/Dockerfile .

build-rpi: arm64
	docker buildx build --platform linux/arm64 --build-arg BASE_IMAGE=$(IMAGE_REPO):${VERSION}-$(COMMIT_HASH) --tag $(IMAGE_REPO):${VERSION}-$(COMMIT_HASH)-rpi --file docker/build/rpi/Dockerfile .

push-rpi: build-rpi
	docker buildx build --push --platform linux/arm64 --build-arg BASE_IMAGE=$(IMAGE_REPO):${VERSION}-$(COMMIT_HASH) --tag $(IMAGE_REPO):${GITHUB_REF_NAME}-$(COMMIT_HASH)-rpi --file docker/build/rpi/Dockerfile .

If these sub makefiles use the same pattern of make targets (i.e. build-{board-name} and push-{board-name}), we can include them in the top-level makefile like so:

BOARDS= #Initialized empty

include docker/build/*/*.mk

build-boards: $(BOARDS:%=build-%)

push-boards: $(BOARDS:%=push-%)

It is also possible to build any of the board-specific targets directly, such as doing make local-rpi.

[madsciencetist]

Consider moving docker/* (excluding docker/build) into docker/build/main, as those files are all referenced exclusively by docker/build/main/Dockerfile, and then omitting the now-superfluous build directory by moving its children up a level

[madsciencetist]

Consider moving requirements.txt files into docker directories as well - at least requirements-tensorrt.txt into docker/tensorrt

[madsciencetist]

Approved - I was able to rebase the Jetson changes elegantly on top of this.