Fix recording segment management #8220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frigate-docs canceled.
|
NickM-27
force-pushed
the
fix-missing-segment
branch
from
063d7dd
to
e36cabe
Compare
|
also, I watched my segments and saw qsize errors but checking the DB and nothing before or after was missing from the DB. All segments with 0 objects / 0 motion were correct. I don't think this is an indication of an error and the logs will lead to confusion and worry when there is no reason for it. I think these are better as debug logs to be used after a user has actually experienced missing segments |
NickM-27
force-pushed
the
fix-missing-segment
branch
from
ef6c471
to
44fb4da
Compare
blakeblackshear
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8162
With the blocking call in this queue and enough cameras with high enough detect fps (I have 7 cameras, some running at 8 detect fps with others running at 5). With a detect fps of 5 something will be put into the recordings info queue every 0.2 seconds, and with multiple cameras and a timeout of 0.1 there is an extremely high chance that frigate will essentially sit there for way too long reading from the recordings info queue because new info is constantly being put into the queue.