Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate region boxes from motion when autotracking #8306

Merged
merged 4 commits into from Oct 24, 2023
Merged

Don't generate region boxes from motion when autotracking #8306

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f131e8
no region boxes from motion boxes when ptz moving
hawkeye217 Oct 23, 2023
d48b1fb
debug contours and calibration
hawkeye217 Oct 24, 2023
96c0db5
remove debugging
hawkeye217 Oct 24, 2023
4406272
clarifying comment
hawkeye217 Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions frigate/video.py
View file
Open in desktop
Expand Up @@ -24,6 +24,7 @@
from frigate.motion import MotionDetector
from frigate.motion.improved_motion import ImprovedMotionDetector
from frigate.object_detection import RemoteObjectDetector
from frigate.ptz.autotrack import ptz_moving_at_frame_time
from frigate.track import ObjectTracker
from frigate.track.norfair_tracker import NorfairTracker
from frigate.types import PTZMetricsTypes
Expand Down Expand Up @@ -627,8 +628,13 @@ def process_frames(
)
]

# only add in the motion boxes when not calibrating
if not motion_detector.is_calibrating():
# only add in the motion boxes when not calibrating and a ptz is not moving via autotracking
# ptz_moving_at_frame_time() always returns False for non-autotracking cameras
if not motion_detector.is_calibrating() and not ptz_moving_at_frame_time(
frame_time,
ptz_metrics["ptz_start_time"].value,
ptz_metrics["ptz_stop_time"].value,
):
# find motion boxes that are not inside tracked object regions
standalone_motion_boxes = [
b for b in motion_boxes if not inside_any(b, regions)
Expand Down