Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API recordings snapsnot PNG fix #8401

Merged

Conversation

tpjanssen
Copy link
Contributor

@tpjanssen tpjanssen commented Oct 31, 2023

Query can have multiple results in case the frame time is on a recording segment boundary:

image

In that case we should use the latest one.

@tpjanssen tpjanssen changed the title Update http.py API recordings snapsnot PNG fix Oct 31, 2023
@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented Oct 31, 2023

Interesting, with this being the case I would suggest after the sort there should also be a .limit(1) and maybe a comment explaining how this can happen

Limit query results
@tpjanssen
Copy link
Contributor Author

Added query limit

Copy link

netlify bot commented Oct 31, 2023

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit 21fbe34
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/65412295dd72cf0008c4d794
😎 Deploy Preview https://deploy-preview-8401--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blakeblackshear blakeblackshear merged commit fd6a3bd into blakeblackshear:dev Nov 1, 2023
10 checks passed
@tpjanssen tpjanssen deleted the api-recordings-snapshot-png-fix branch November 19, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants