Adding go2rtc presets for Rockchip hardware acceleration #8686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works using this syntax:
However, this does not work and uses software decoding instead:
Is this normal behavior, because this preset was added using the config and not as a default preset?
And what about decoding? go2rtc calls FFmpeg this way:
ffmpeg -hide_banner -re -i /config/Big_Buck_Bunny_1080_hevc.mp4 -c:v libx264 -g 50 -profile:v high -level:v 4.1 -preset:v superfast -tune:v zerolatency -pix_fmt:v yuv420p -an -user_agent ffmpeg/go2rtc -rtsp_transport tcp -f rtsp {output}
So, no decoder is specified and and FFmpeg auto selects one. As far as I can see, this is the way it's done in go2rtc (selecting the encoder and not selecting decoder). Is this correct or should I also add decoding presets that can be passed using
#input=hevc/rk_dec
?