Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear plus id of submitted events #8729

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

tpjanssen
Copy link
Contributor

Useful when the wrong button in the front-end is pressed.

@blakeblackshear

Maybe we can add logic here to automatically clear the image on Frigate+ side as well?

Copy link

netlify bot commented Nov 23, 2023

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit 580832d
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/655f77de90348200084d6304
😎 Deploy Preview https://deploy-preview-8729--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Sponsor Collaborator

@NickM-27 NickM-27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will cause issues if frigate+ is out of sync and I don't see a reason for this since it can be corrected on the frigate+ dashboard side

@tpjanssen
Copy link
Contributor Author

Today I reported a false positive as a positive. A false positive would normally result in a red bounding box. There is no way to turn the submitted positve bounding box into a red one used for indicating false positives. The other way around is just a matter of deleting the red box and create your own new one.

@tpjanssen
Copy link
Contributor Author

I don't think anything gets of out sync, as the plus id seems to be a random generated string.

@NickM-27
Copy link
Sponsor Collaborator

We're not planning any more features or UI changes in 0.13. This would only be usable as a manual API call and again would require a change in frigate+ otherwise there are duplicate images still in frigate+

Probably makes sense to pin this and consider for 0.14

@tpjanssen
Copy link
Contributor Author

I fully understand. That's why I only added it in the Frigate backend. I tested it myself, if you use the function to clear the plus id you can resend it to Frigate+. If you don't delete your previous image probably the same image is used twice during training.

This can happen already. I have seen events in my feed where two objects get detected at the same time, resulting in events with exactly the same snapshot.

@tpjanssen
Copy link
Contributor Author

Is it possible to add this function as it is now, and do a revamp on this in 0.14?

@NickM-27
Copy link
Sponsor Collaborator

I don't think it serves much purpose, since the user would need to know it exists and call the API via CLI

And at this point only bug fixes are going to be put in to 0.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants