-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear plus id of submitted events #8729
base: dev
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for frigate-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will cause issues if frigate+ is out of sync and I don't see a reason for this since it can be corrected on the frigate+ dashboard side
Today I reported a false positive as a positive. A false positive would normally result in a red bounding box. There is no way to turn the submitted positve bounding box into a red one used for indicating false positives. The other way around is just a matter of deleting the red box and create your own new one. |
I don't think anything gets of out sync, as the plus id seems to be a random generated string. |
We're not planning any more features or UI changes in 0.13. This would only be usable as a manual API call and again would require a change in frigate+ otherwise there are duplicate images still in frigate+ Probably makes sense to pin this and consider for 0.14 |
I fully understand. That's why I only added it in the Frigate backend. I tested it myself, if you use the function to clear the plus id you can resend it to Frigate+. If you don't delete your previous image probably the same image is used twice during training. This can happen already. I have seen events in my feed where two objects get detected at the same time, resulting in events with exactly the same snapshot. |
Is it possible to add this function as it is now, and do a revamp on this in 0.14? |
I don't think it serves much purpose, since the user would need to know it exists and call the API via CLI And at this point only bug fixes are going to be put in to 0.13 |
Useful when the wrong button in the front-end is pressed.
@blakeblackshear
Maybe we can add logic here to automatically clear the image on Frigate+ side as well?