Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle onvif connection failure in autotrack init #8838

Merged
merged 4 commits into from Dec 3, 2023
Merged

handle onvif connection failure in autotrack init #8838

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bdd8843
handle onvif connection failure in autotrack init
hawkeye217 Dec 2, 2023
dfe1dd7
remove whitespace and add consistency
hawkeye217 Dec 2, 2023
236f1c2
error message consistency
hawkeye217 Dec 2, 2023
86b1b5b
more consistency
hawkeye217 Dec 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 16 additions & 8 deletions frigate/ptz/autotrack.py
View file
Open in desktop
Expand Up @@ -238,32 +238,40 @@ def _autotracker_setup(self, camera_config, camera):
self.move_queues[camera] = queue.Queue()
self.move_queue_locks[camera] = threading.Lock()

# handle onvif constructor failing due to no connection
if camera not in self.onvif.cams:
logger.warning(
f"Disabling autotracking for {camera}: onvif connection failed"
)
camera_config.onvif.autotracking.enabled = False
self.ptz_metrics[camera]["ptz_autotracker_enabled"].value = False
return

if not self.onvif.cams[camera]["init"]:
if not self.onvif._init_onvif(camera):
logger.warning(f"Unable to initialize onvif for {camera}")
logger.warning(
f"Disabling autotracking for {camera}: Unable to initialize onvif"
)
camera_config.onvif.autotracking.enabled = False
self.ptz_metrics[camera]["ptz_autotracker_enabled"].value = False

return

if "pt-r-fov" not in self.onvif.cams[camera]["features"]:
camera_config.onvif.autotracking.enabled = False
self.ptz_metrics[camera]["ptz_autotracker_enabled"].value = False
logger.warning(
f"Disabling autotracking for {camera}: FOV relative movement not supported"
)

camera_config.onvif.autotracking.enabled = False
self.ptz_metrics[camera]["ptz_autotracker_enabled"].value = False
return

movestatus_supported = self.onvif.get_service_capabilities(camera)

if movestatus_supported is None or movestatus_supported.lower() != "true":
camera_config.onvif.autotracking.enabled = False
self.ptz_metrics[camera]["ptz_autotracker_enabled"].value = False
logger.warning(
f"Disabling autotracking for {camera}: ONVIF MoveStatus not supported"
)

camera_config.onvif.autotracking.enabled = False
self.ptz_metrics[camera]["ptz_autotracker_enabled"].value = False
return

if self.onvif.cams[camera]["init"]:
Expand Down