Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Changing nested tag parents causes empty tags to be visible in tag tree #37

Closed
blakedietz opened this issue Mar 12, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@blakedietz
Copy link
Owner

blakedietz commented Mar 12, 2019

Description

For some reason changing a file that was tagged with 2019/02/26 to tsheets/2019/02/26 caused some tags to be orphaned.

What are the steps to reproduce this issue

  1. Make a nested tag such as foo/bar.
  2. Look at the tag tree and note that foo/bar exist.
  3. Replace foo/bar with boo/bar

Images or video

See the image for an example.

2019-02-26 md — notes (Workspace) 2019-03-12 15-01-06

What happens

The previous top level tag in the tag tree remains.

What were you expecting to happen

The previous top level tag in the tree should be removed.

Debug information

Any other comments

What versions of software are you using

Operating System

macOS Mojave

vscode version

latest

Plugin version

1.2.0

@blakedietz blakedietz added the bug Something isn't working label Mar 12, 2019
blakedietz added a commit that referenced this issue Mar 28, 2019
When renaming a tag with hierarchy, if the root node was renamed, when
removing the path to the node, parents would not be properly cleaned up.

Closes #37
blakedietz added a commit that referenced this issue Mar 28, 2019
When renaming a tag with hierarchy, if the root node was renamed, when
removing the path to the node, parents would not be properly cleaned up.

Closes #37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant