Detected and fixed an issue related to -0 #20
Conversation
dubzzz
force-pushed
the
master
branch
2 times, most recently
from
872a59a
to
fa059d7
Compare
javascript-stringify.js
Outdated
| @@ -214,7 +214,10 @@ | |||
| 'string': function (string) { | |||
| return "'" + string.replace(ESCAPABLE, escapeChar) + "'"; | |||
| }, | |||
| 'number': String, | |||
| 'number': function (val) { | |||
| if (val === 0 && 1 / val === -Infinity) return '-0'; | |||
There was a problem hiding this comment.
What about using Object.is? I realize this has much better compatibility though, so LGTM!
There was a problem hiding this comment.
Indeed, I believed Object.is was not part of Node 4, but it is.
| @@ -331,4 +334,21 @@ describe('javascript-stringify', function () { | |||
| test(obj, '{a:{b:{}}}', null, { maxDepth: 2, references: true }) | |||
| ); | |||
| }); | |||
| describe('property based', function () { | |||
| var customEval = function (repr) { | |||
There was a problem hiding this comment.
Would it make sense to just use eval for now? I'm not sure we need the additional wrapper.
There was a problem hiding this comment.
I think I had an issue with eval, but I will try again ;)
There was a problem hiding this comment.
Calling console.log(eval("{}")) prints undefined.
Calling console.log(eval("(function () { return {}; })()")); does work.
So I can either have:
var customEval = function (repr) {
return eval("(function () { return " + repr + "; })()");
};or
var customEval = function (repr) {
return Function("return " + repr)();
};There was a problem hiding this comment.
That makes sense, since it's a block. All good 👍
| @@ -331,4 +334,21 @@ describe('javascript-stringify', function () { | |||
| test(obj, '{a:{b:{}}}', null, { maxDepth: 2, references: true }) | |||
| ); | |||
| }); | |||
| describe('property based', function () { | |||
|
I love the idea of |
|
Concerning the generation of regex, I wrote a snippet doing that few days ago: https://runkit.com/dubzzz/valid-regex-generator It is still incomplete but it is a good start ^^ I will maybe include such generator in fast-check ;) |
I detected and fixed an issue with -0 by using property based tests.