Removing no-unused-variable for tslint 4.0

[unional]

palantir/tslint#1481

It is deprecated in favor of:
https://github.com/Microsoft/TypeScript/wiki/What%27s-new-in-TypeScript#flag-unused-declarations-with---nounusedparameters-and---nounusedlocals

But don't release until https://github.com/Microsoft/vscode-tslint/issues/123 is fixed.

[mdurling]

The following rules all have been deprecated and must be removed:

no-unused-variable
no-duplicate-key
no-unreachable

[unional]

Fixed tests

[unional]

vscode-tslint fix is release. Good to go. But seems like tests is not triggered.

Project config issue.

[mdurling]

The tslint-eslint-rules package also needs to be updated and the two additional rules removed. See PR #14

[unional]

Sure. Let's use your PR. Closing this one.

[mdurling]

Travis is failing my CI tests. They pass on my local machine. I had to run npm test:gen to create the .out files. Can you take a look? Am I missing something?

[unional]

Clear your local node_modules and try again. I think the eslint-rules has changed its distribution 👎

[unional]

Oh, nope. It's eslint-rules need to update to 4.0 first.
It is doing require('tslint/lib/lint') which does not exists in 4.0.

[unional]

Ref: buzinas/tslint-eslint-rules#137

[mdurling]

I was getting this error locally until I updated tslint-eslint-rules (which
I included in my PR) and then it worked.

On Mon, Nov 21, 2016 at 11:50 AM Homa Wong notifications@github.com wrote:

Ref: buzinas/tslint-eslint-rules#137
buzinas/tslint-eslint-rules#137

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADR8_WMYPNOulKEuTVvK1T7OvDSV257Uks5rAcvNgaJpZM4K3Xbb
.

[unional]

I just tried it and 2.2.1 is not working yet.

[mdurling]

It works on my local machine, but tslint-eslint-rules has its own nested copy of tslint (3.15.1)

[unional]

It does say unmet deps for me and using 4.0.1, thus the error. Which version of npm are you using?
I'm using 3.10.3