Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use inflection.camelize instead str.istitle #1

Merged
merged 1 commit into from
Jun 19, 2020
Merged

use inflection.camelize instead str.istitle #1

merged 1 commit into from
Jun 19, 2020

Conversation

eyllanesc
Copy link
Contributor

@eyllanesc eyllanesc commented Jun 18, 2020

According to PEP 8 the classes must be CapWords so the CustomTabBar class name is valid, but if a qss is parsed with that class it is converted to "custom-tab-bar" which is incorrect. This PR tries to solve it.

@blambright
Copy link
Owner

Good catch! Thanks for this.

@blambright blambright merged commit 7a520c3 into blambright:master Jun 19, 2020
@blambright
Copy link
Owner

Released in 0.1.6

@eyllanesc eyllanesc deleted the class_name_camelcase branch June 19, 2020 03:00
@eyllanesc eyllanesc restored the class_name_camelcase branch June 19, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants