Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python and PHP code examples #2

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

yadutaf
Copy link

@yadutaf yadutaf commented Mar 31, 2017

This is a first PR from this week's Hackathon. This PR adds code generation, based on what's done on https://api.ovh.com/console with a couple of nice additions:

  • It generates valid code (Yes, that's a feature, hum, hum)
  • It supports arbitrarily nested structures
  • It brings syntax highlighting, making the current production code look... terribly old
  • It only generates required arguments
  • It supports all json types (lists will be in a future PR to keep things clean)

I'm definitively NOT a js developer. Although I'd be glad if this PR is accepted as-is, I'd be even happier with an in-depth review, especially regarding modules organization and lib vendoring.

@yadutaf
Copy link
Author

yadutaf commented Mar 31, 2017

If you want to get a glimpse on the futures changes, you may have a look at https://github.com/yadutaf/ovh-api-console/tree/jt. In particular, I believe the next commit will be yadutaf@d246f8b. I feel quite comfortable about it and this is a necessary feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant