-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows support through vcpkg #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion 👍
vcpkg looks to be better choice than the ways in the wiki page of OpenBLAS. This is a good start point to support Windows, though we have still a problem, to manage CBLAS
and LAPACKE
flags, and architecture problem discussed in OpenMathLib/OpenBLAS#2256. These problems should be other issues, and I think it is better to merge this PR as it is with some minor fix and CI setup.
Thanks @termoshtt Co-authored-by: Toshiki Teramura <toshiki.teramura@gmail.com>
Co-authored-by: Toshiki Teramura <toshiki.teramura@gmail.com>
Okay I believe I have resolved all of the things @termoshtt requested. I still need to make CI work. Is MSYS a supported platform? I'm not sure how to detect this. Perhaps target_os = windows but target_family=unix? I'll have to look into it. Perhaps do detection based on the compiler triple if I can do that? |
Good catch 💯
Although the CI of master currently fails (#38), it should be supported. So the build way matrix is here:
This table suggests us that we should switch by If you are not familiar with AppVeyor, feel free to let me know. I will fix them with #38 |
@termoshtt feel free to fix CI, I'm not familiar enough with Appveyor CI to set up vcpkg and it seems the msys builds are broken too. |
Appveyor is a project in itself. I don’t think it ever worked for this repository. There is also an issue for this; see #38. |
Thanks a lot! |
Absolutely, I'll rebase #37 on this and add the feature next :) |
I can set up CI for this a bit later, but I wanted to hear your thoughts on this as a solution to Windows support.