Skip to content

Commit

Permalink
mmc: sdhci: Don't spew on CRC errors
Browse files Browse the repository at this point in the history
Register dumps for CRC errors are not very useful and they spam
the logs.

Change-Id: I057ba45e6a9b0ae34d997f0f9e465e9ad63f3f62
Signed-off-by: Russ Knize <Russ.Knize@motorola.com>
Reviewed-on: http://gerrit.mot.com/629213
SLTApproved: Slta Waiver <sltawvr@motorola.com>
Tested-by: Jira Key <jirakey@motorola.com>
Reviewed-by: Igor Kovalenko <igork@motorola.com>
Submit-Approved: Jira Key <jirakey@motorola.com>
Signed-off-by: Zdrowy Gosciu <ZdrowyGosciu+GITHUB@gmail.com>
  • Loading branch information
Russ W. Knize authored and Rashed97 committed Apr 14, 2016
1 parent d5d54ad commit 0464a97
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions drivers/mmc/host/sdhci.c
Original file line number Diff line number Diff line change
Expand Up @@ -2676,7 +2676,7 @@ static void sdhci_show_adma_error(struct sdhci_host *host)
static void sdhci_data_irq(struct sdhci_host *host, u32 intmask)
{
u32 command;
bool pr_msg = false;
bool pr_msg = true;
BUG_ON(intmask == 0);

/* CMD19 generates _only_ Buffer Read Ready interrupt */
Expand Down Expand Up @@ -2721,9 +2721,10 @@ static void sdhci_data_irq(struct sdhci_host *host, u32 intmask)
host->data->error = -EILSEQ;
else if ((intmask & SDHCI_INT_DATA_CRC) &&
SDHCI_GET_CMD(sdhci_readw(host, SDHCI_COMMAND))
!= MMC_BUS_TEST_R)
!= MMC_BUS_TEST_R) {
host->data->error = -EILSEQ;
else if (intmask & SDHCI_INT_ADMA_ERROR) {
pr_msg = false;
} else if (intmask & SDHCI_INT_ADMA_ERROR) {
pr_err("%s: ADMA error\n", mmc_hostname(host->mmc));
sdhci_show_adma_error(host);
host->data->error = -EIO;
Expand All @@ -2735,12 +2736,10 @@ static void sdhci_data_irq(struct sdhci_host *host, u32 intmask)
if ((command != MMC_SEND_TUNING_BLOCK_HS400) &&
(command != MMC_SEND_TUNING_BLOCK_HS200) &&
(command != MMC_SEND_TUNING_BLOCK)) {
pr_msg = true;
if (intmask & SDHCI_INT_DATA_CRC)
host->flags |= SDHCI_NEEDS_RETUNING;
}
} else {
pr_msg = true;
} else
pr_msg = false;
}
if (pr_msg) {
pr_err("%s: data txfr (0x%08x) error: %d after %lld ms\n",
Expand Down

0 comments on commit 0464a97

Please sign in to comment.