Fixed tkinter and local imports #93
Conversation
|
Hey @Sory-Noroc welcome to the crew. :) |
|
First of all, Thank you for your contribution.
other than that- everything looks good. blavejr will accept it as soon as he checks the code. |
|
I agree with @KokoseiJ, the try might not be the best solution unless there is another reason. |
| Frame.__init__(self, master) | ||
| self.pack() | ||
| self.create() | ||
| self.folders = [x for x in Extensions] |
There was a problem hiding this comment.
This is a good initiative, but you would need to change all the folders variables to self.folder otherwise it will not use self.folder at all.
|
You might be right but I was getting an ImportError with the previous
version from that tkMessageBox
Lun, 15 mar. 2021, 22:56 Remigius Kalimba Jr ***@***.***> a
scris:
… I agree with @KokoseiJ <https://github.com/KokoseiJ>, the try might not
be the best solution unless there is another reason.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#93 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOWHLJ4NHMQBGXMUGYMILVTTDZYA3ANCNFSM4ZDR2UCQ>
.
|
| else: | ||
| from tkinter import * | ||
| except ImportError: | ||
| from Tkinter import * | ||
| import tkMessageBox | ||
|
|
||
| pwd = os.path.dirname(os.path.abspath(__file__)) | ||
| Extensions = json.load(open(pwd+'/Extension.json', 'r')) |
There was a problem hiding this comment.
You could probably move these 2 into the class too as class constants
Hmmm are you running this on python3? because in that case we might be missing something |
|
Yes, ofc Im running it on python3
Lun, 15 mar. 2021, 23:05 Remigius Kalimba Jr ***@***.***> a
scris:
… You might be right but I was getting an ImportError with the previous
version from that tkMessageBox Lun, 15 mar. 2021, 22:56 Remigius Kalimba Jr
*@*.***> a scris:
… <#m_8996315261215186939_>
I agree with @KokoseiJ <https://github.com/KokoseiJ>
https://github.com/KokoseiJ, the try might not be the best solution
unless there is another reason. — You are receiving this because you were
mentioned. Reply to this email directly, view it on GitHub <#93 (comment)
<#93 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOWHLJ4NHMQBGXMUGYMILVTTDZYA3ANCNFSM4ZDR2UCQ
.
Hmmm are you running this on python3? because in that case we might be
missing something
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#93 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOWHLJ5EMRT5GSNQ4OAVGG3TDZZCJANCNFSM4ZDR2UCQ>
.
|
Hey!
I am a new contributor, also new to Git, so I would appreciate if you would accept me in this project, and perhaps guide me as I develop/contribute to the app. :)