General updates, improvement, and clean up #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will remove `read_idx` in a future version.
For example `fxx="6H"`
It was silly, I just needed close the file opened by pygrib. This has been hanging over my head a long time.
blaylockbk
changed the title
read_idx method to inventory, added method to FastHerbie, and improve searchString examples.read_idx method to inventory, added method to FastHerbie, and improve searchString examples.
blaylockbk
changed the title
read_idx method to inventory, added method to FastHerbie, and improve searchString examples.…rve-searchString-examples-and-discovery
blaylockbk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a few things that I've been meaning to do for a while.
herbie.archivetoherbie.core. (the name "archive" was starting to loose its meaning, since some models are not "archived", only available for a few days or weeks). This shouldn't impact anyone doingfrom herbie import Herbieherbie/fast.pyfile.H.read_idx()toH.inventory()because it's easier to remember. I kept the old method and added a Deprecation warning thatread_idxwill be removed at a future release.inventorymethod was also added to FastHerbie so a user can look at all the fields that would be downloaded before executing a download.searchStringexamples for precipitation in the documentation (Search string for one hour precip fails. Lots of corner cases #156)fxxargument to accept a pandas-parsable timedelta string, (e.g., "6H").docs/_builddirectory because it is now built by readthedocs. (Directory is still in git history that should probably be removed if it won't ruin Herbie.)