Speed up Herbie.xarray by Reusing local_file #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for finding this! Definitely is an improvement. Yes, there are more obvious improvments that could help Herbie run faster. I'll look at using the local_file in download. And thanks for giving back to Herbie! I hope it has been useful to you. |
|
It was! Thanks for making it public! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing a quick profiling,
get_localFilePathwas taking up the majority of time of a call toxarray, so reusing the computed value speeds up the function quite a bit. If you think this approach is reasonable, another improvement might even be passing the computed index andlocal_filetodownload, so that it doesn't need to recompute these either.