Blaylockbk/issue52 Add some multithreading tools to Herbie #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some tools that use multithreading to make some processes faster.
Creating a Herbie object is a lot of network traffic (Herbie check if a GRIB file exits at a lot of different remote archives and also looks for index files). Herbie also downloads the GRIB2 files, which is also mainly done over the network, and reading the data into xarray depends on the downloads.
Multithreading is useful for I/O bound tasks. As I understand, communication across the internet falls under this category. So multi threads can be helpful when creating many Herbie objects.
This pull request applies multithreading for the following tasks:
herbie.tools.fast_Herbie)herbie.tools.fast_Herbie_download)herbie.tools.fast_Herbie_xarray)I'll add some documentation before making a new Herbie release.