Adds msgpack as a blaze server serial format #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,7 +2,12 @@ | |||
| from functools import partial | |||
| import json as json_module | |||
|
|
|||
| from ..compatibility import pickle, unicode | |||
| try: | |||
| import msgpack as msgpack_module | |||
There was a problem hiding this comment.
I suggest grabbing the implementation in pandas.msgpack. It's a bit faster.
|
does this get tested automatically? |
|
The tests are parameterized over |
|
cool |
|
merge when ready |
llllllllll
added a commit
that referenced
this pull request
Jun 11, 2015
Adds msgpack as a blaze server serial format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server tests test against this format also because it is in
all_formats.Adds the msgpack format as discussed here: #982
I didn't see msgpack in the requirements so I made it optional.