Fix scalar_coerce for nan->nat #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llllllllll
force-pushed
the
coerce_scalar-nan-to-datetime
branch
from
472ebc9
to
2702ee6
Compare
|
you should conditionally check results based on the pandas version |
what's the reason for doing this? |
|
Should we be checking the output because of the reduction fix that was just merged? I still think that it is reasonable to coerce an explicitly passed |
llllllllll
added a commit
that referenced
this pull request
Oct 13, 2015
Fix scalar_coerce for nan->nat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug also prevented me from taking the min of an empty series of
datetime64in pandas when using the blaze server because the server was trying to scaler_coerce thenaninto adatetime.datetime.