New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scalar_coerce for nan->nat #1272

Merged
merged 1 commit into from Oct 13, 2015

Conversation

Projects
None yet
3 participants
@llllllllll
Member

llllllllll commented Oct 12, 2015

This bug also prevented me from taking the min of an empty series of datetime64 in pandas when using the blaze server because the server was trying to scaler_coerce the nan into a datetime.datetime.

@llllllllll llllllllll changed the title from DOC: add whatsnew to Fix scalar_coerce for nan->nat Oct 12, 2015

@llllllllll llllllllll force-pushed the quantopian:coerce_scalar-nan-to-datetime branch from 472ebc9 to 2702ee6 Oct 12, 2015

@jreback

This comment has been minimized.

Contributor

jreback commented Oct 12, 2015

you should conditionally check results based on the pandas version

@cpcloud

This comment has been minimized.

Member

cpcloud commented Oct 12, 2015

you should conditionally check results based on the pandas version

what's the reason for doing this?

@cpcloud cpcloud added this to the 0.9.0 milestone Oct 12, 2015

@llllllllll

This comment has been minimized.

Member

llllllllll commented Oct 12, 2015

Should we be checking the output because of the reduction fix that was just merged? I still think that it is reasonable to coerce an explicitly passed nan just like pd.Timestamp does.

llllllllll added a commit that referenced this pull request Oct 13, 2015

@llllllllll llllllllll merged commit e1d2e06 into blaze:master Oct 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@llllllllll llllllllll deleted the quantopian:coerce_scalar-nan-to-datetime branch Oct 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment