Optional relationals #1292
Merged
Optional relationals #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like we need to import pytest |
MAINT: fix _dtype property in Not class. TST: fix tests. TST: clean up imports. TST: fix imports
|
Yup, sorry. I removed that mistakenly. It's back now. |
mtydykov
force-pushed
the
optional-relationals
branch
from
b91f6ba
to
a40d1a7
Compare
|
Can you add a new entry to the whatsnew? |
|
Sure - which file to I add it to? For the latest version, there's BASE, LOCAL, and REMOTE. I think those were somehow created automatically, and I'm not sure what to do with them. |
|
docs/source/whatsnew/0.9.0.txt |
|
Done. |
DOC: fix whatsnew entry.
mtydykov
force-pushed
the
optional-relationals
branch
from
46cd018
to
4efd105
Compare
| def test_relations_are_boolean(): | ||
| assert Gt(x, y).schema == dshape('bool') | ||
| @pytest.mark.parametrize('relation_type', Relational.__subclasses__()) | ||
| @pytest.mark.parametrize('lhs,rhs', product((x, y, d, e, f), repeat=2)) |
There was a problem hiding this comment.
neat! i didn't realize you could chain these
|
i'm going to resolve the merge conflicts here and merge on passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify Arithmetic classes so that operations with optionals result in an optional type and add associated tests.