Add some of the lowhanging fruit from dask.dataframe #1317
Conversation
| def compute_up(expr, data, **kwargs): | ||
| values = [compute(val, {expr._child: data}) for val in expr.values] | ||
| if expr.keepdims: | ||
| return DataFrame([values], columns=expr.fields) | ||
| if isinstance(data, Dataframe): |
There was a problem hiding this comment.
this could be type(data)(...)
There was a problem hiding this comment.
this is also a typo Dataframe should be DataFrame ... i think type(self)(...) would solve the problem
There was a problem hiding this comment.
Thanks, that is much better.
|
looks like dask dataframes are missing a shape attribute ... does that even make sense for that object? |
|
No, dask.dataframes do not know their own length, except through computation. |
|
@cowlicks You'll probably have to implement a new dispatched version of those expressions. |
|
@cowlicks You could probably do |
cowlicks
force-pushed
the
dataframe
branch
2 times, most recently
from
2cb3a94
to
238c963
Compare
|
The cost of |
|
@mrocklin I'll leave it out then. |
|
I'd be okay with leaving out |
|
@cowlicks On second thought, I still think |
|
@cpcloud any idea why this call to count does not dispatch to here? |
|
because the test is operating on a |
cowlicks
changed the title
|
This is not comprehensive, but includes a lot of easy stuff from dask dataframe. I believe the tests cover all the added |
|
@cowlicks can you add a release note in |
|
Added release notes. Merging soon unless there are further comments. |
Add some of the lowhanging fruit from dask.dataframe
No description provided.