Use flask-cors package for CORS; don't use Bokeh anymore. #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Bokeh 0.11, the CORS handling was moved. This removes the Bokeh dependency for this part of Blaze and uses instead a small MIT-licensed flask extension.
| @@ -219,7 +209,7 @@ def run(self, port=DEFAULT_PORT, retry=False, **kwargs): | |||
|
|
|||
|
|
|||
| @api.route('/datashape', methods=['GET']) | |||
| @crossdomain(origin='*', methods=['GET']) | |||
| @cross_origin(origins='*', methods=['GET']) | |||
There was a problem hiding this comment.
We need to consider if we want to let any and all browser content to load from the Blaze server, as the * essentially defeats the cross-origin content loading protection. Might want to eventually move toward making this configurable or default to localhost:6363?
There was a problem hiding this comment.
I'm in agreement with you; this PR is scoped to just reproduce the current functionality with the flask-cors extension. I'll make a separate feature request for making this configurable.
|
Looks good! |
kwmsmith
added a commit
that referenced
this pull request
Jan 11, 2016
Use flask-cors package for CORS; don't use Bokeh anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Bokeh 0.11, the CORS handling was moved. This removes the Bokeh
dependency for this part of Blaze and uses instead a small MIT-licensed
flask extension.