-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1358 rename Data to data #1421
1358 rename Data to data #1421
Conversation
@@ -310,3 +310,13 @@ def __get__(self, instance, owner): | |||
return self | |||
|
|||
return self._f(instance) | |||
|
|||
|
|||
class BlazeDeprecationWarning(DeprecationWarning): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason to make these classes rather than just using the superclass directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We originally thought it would be good to have a subclass to make it easily filterable, but now I'm with you, and see no really good reason not to just use DeprecationWarning
directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea was to so that we can set warnings.simplefilter
to only display the warning once but I couldn't get it to work. I created the derived class so that I wouldn't effect how other warnings are displayed, especially since deprecation warnings are ignored by default.
How do people feel about the name, |
As you know, we discussed this at length in another issue thread. We bikeshedded the naming question again among 4-5 people before starting this PR. We decided to stay with
|
@llllllllll I agree that At the risk of starting another lengthy discussion, I propose that if we were to change the name that it be simple. So something like But we shouldn't delay progress, rather just keep the discussion open and make a decision before we get to a 1.0. |
@kwmsmith Sorry, I forgot that we had come to a conclusion in the other thread. |
Closing this PR, see #1431. |
closes #1358
rename Data to data and add deprecation warning to Data.