Complete Data to data rename
#1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames the `InteractiveSymbol` class to `_Data`, and deprecates `InteractiveSymbol`. In version 0.11, `InteractiveSymbol` will be removed, and the `_Data` class will be renamed `Data`. This is all to be consistent with other function / class naming schemes, that have a lowercase entry point that creates an instance of the CamelCased class.
`data()` will dispatch to `odo.resource()` when needed. This change ensures that many of the edge cases in `data()` are tested.
| @@ -41,19 +41,27 @@ | |||
| not_an_iterator.append(pymongo.database.Database) | |||
|
|
|||
|
|
|||
| class InteractiveSymbol(Symbol): | |||
| """Interactive data. | |||
| class _Data(Symbol): | |||
There was a problem hiding this comment.
should we just call this Data to match the other expression/smart constructor pairs?
There was a problem hiding this comment.
Yes, that's exactly the ultimate intent, and in version 0.11 we'll remove InteractiveSymbol and rename _Data to Data. I made note of this in the whatsnew document.
There was a problem hiding this comment.
Ah, I should read the whole change before commenting; sorry
kwmsmith
added a commit
that referenced
this pull request
Feb 26, 2016
Complete `Data` to `data` rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on PR #1421:
Dataare replaced withdata;Dataare deprecated;InteractiveSymbolis deprecated and replaced by_Data;datacreate an instance of_Data;odo.resourceare replaced byblaze.datathroughout the codebase and testsuite.In version 0.11, the following changes will take place, to complete the transition:
InteractiveSymbolwill be removed;_Dataclass will be renamedData, and calls todatawill create aDatainstance;joinandJoin,headandHead, etc.