Fix bug in Pandas compute_up() on Broadcast exprs. #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds broadcast tests for Pandas frames / series and Dask dataframes.
| def test_frame_broadcast(): | ||
| bcast = broadcast_collect(expr=t.amount * t.id) | ||
| result = compute(bcast, df) | ||
| assert_series_equal(df.amount * df.id, result) |
There was a problem hiding this comment.
can we swap the assertion to make the lhs the result and the rhs the expected? I know that this is equivalent but that pattern is more common
|
Thanks for the test coverage, looks good! |
kwmsmith
added a commit
that referenced
this pull request
Mar 10, 2016
Fix bug in Pandas compute_up() on Broadcast exprs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds broadcast tests for Pandas frames / series and Dask dataframes.