-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sample with frac
argument on postrgres backend.
#1452
Conversation
Add failing test and mark with xfail.
Have to add a `from_obj` clause inside the sub-select.
ping @sandhujasmine |
Looks good - it contains tests for various And
Would be good to have consistent behavior if looking at same data either from files or loaded up in DB. This is more when testing the same symbolic (unbound) expression against different resources. Maybe we should work towards merging this as is, then add failing tests to reproduce above cases, then work on solutions? |
Fix sample with `frac` argument on postrgres backend.
Subsumes #1425 and #1424.
Closes #1423.