BUG: fix isin for server #1255
Merged
BUG: fix isin for server #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llllllllll
force-pushed
the
serialize-frozenset
branch
4 times, most recently
from
9b6c768
to
b97438a
Compare
| @@ -76,6 +76,9 @@ install: | |||
| # Install coveralls | |||
| - pip install coveralls | |||
|
|
|||
| # Install pyyaml | |||
| - pip install PyYAML | |||
There was a problem hiding this comment.
remove this line ... i just merged 082d96a which adds this to travis
There was a problem hiding this comment.
cool, btw, have you given any thought to the 2.6 compat question?
llllllllll
force-pushed
the
serialize-frozenset
branch
5 times, most recently
from
80cf414
to
397b1f0
Compare
|
@cpcloud merging on pass. |
| if not key.startswith('__!'): | ||
| return obj | ||
|
|
||
| return object_hook._converters[key[3:]](obj[key]) |
There was a problem hiding this comment.
can you write this as key[len('__!'):]? IMO this clarifies what you're doing here
|
This was not the PR I meant to merge I saw the comment in my email about the len pr, Sorry about this! |
|
Should I revert or just push the len change? |
|
Just push the On Tue, Oct 13, 2015 at 12:55 PM Joe Jevnik notifications@github.com
|
|
Okay. Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frozenset couldn't be serialized. This also makes deserialization of the datetime give a timestamp.