Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix isin for server #1255

Merged
merged 3 commits into from Oct 13, 2015

Conversation

@llllllllll
Copy link
Member

commented Sep 18, 2015

The frozenset couldn't be serialized. This also makes deserialization of the datetime give a timestamp.

@llllllllll llllllllll force-pushed the quantopian:serialize-frozenset branch 4 times, most recently from 9b6c768 to b97438a Sep 18, 2015

.travis.yml Outdated
@@ -76,6 +76,9 @@ install:
# Install coveralls
- pip install coveralls

# Install pyyaml
- pip install PyYAML

This comment has been minimized.

Copy link
@cpcloud

cpcloud Sep 28, 2015

Member

remove this line ... i just merged 082d96a which adds this to travis

This comment has been minimized.

Copy link
@llllllllll

llllllllll Sep 28, 2015

Author Member

cool, btw, have you given any thought to the 2.6 compat question?

@llllllllll llllllllll force-pushed the quantopian:serialize-frozenset branch 5 times, most recently from 80cf414 to 397b1f0 Oct 8, 2015

@llllllllll

This comment has been minimized.

Copy link
Member Author

commented Oct 13, 2015

@cpcloud merging on pass.

if not key.startswith('__!'):
return obj

return object_hook._converters[key[3:]](obj[key])

This comment has been minimized.

Copy link
@cpcloud

cpcloud Oct 13, 2015

Member

can you write this as key[len('__!'):]? IMO this clarifies what you're doing here

This comment has been minimized.

Copy link
@llllllllll

llllllllll Oct 13, 2015

Author Member

sure

@cpcloud cpcloud added this to the 0.9.0 milestone Oct 13, 2015

llllllllll added a commit that referenced this pull request Oct 13, 2015

@llllllllll llllllllll merged commit 3a0fc77 into blaze:master Oct 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@llllllllll llllllllll deleted the quantopian:serialize-frozenset branch Oct 13, 2015

@llllllllll

This comment has been minimized.

Copy link
Member Author

commented Oct 13, 2015

This was not the PR I meant to merge I saw the comment in my email about the len pr, Sorry about this!

@llllllllll

This comment has been minimized.

Copy link
Member Author

commented Oct 13, 2015

Should I revert or just push the len change?

@cpcloud

This comment has been minimized.

Copy link
Member

commented Oct 13, 2015

Just push the len change

On Tue, Oct 13, 2015 at 12:55 PM Joe Jevnik notifications@github.com
wrote:

Should I revert or just push the len change?


Reply to this email directly or view it on GitHub
#1255 (comment).

@llllllllll

This comment has been minimized.

Copy link
Member Author

commented Oct 13, 2015

Okay. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.