Chunking open_many calls to prevent open file bloat. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When prefetching, the list of keys to load are chunked up to prevent open_many from opening too many files simultaneously. On my system, the user file limit was 1024, so I set it to 512.
maxhutch
added a commit
that referenced
this pull request
Jul 6, 2015
Chunking open_many calls to prevent open file bloat.
| @@ -15,6 +15,7 @@ | |||
| import hashlib | |||
|
|
|||
| DEFAULT_AVAILABLE_MEMORY = 1e9 | |||
| MAX_OPEN_FILES = 512 | |||
There was a problem hiding this comment.
Mac OS-X may be more restrictive here. Suggest 100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When prefetching, the list of keys to load are chunked
up to prevent open_many from opening too many files
simultaneously.
On my system, the user file limit was 1024, so I set it to 512.
This should resolve #14.