Fix writing compressed CSVs in python3 #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TomAugspurger look ok to you? |
| @@ -91,7 +92,10 @@ def append_dataframe_to_csv(c, df, dshape=None, **kwargs): | |||
| encoding=kwargs.get('encoding', c.encoding) | |||
|
|
|||
| if ext(c.path) in compressed_open: | |||
| f = compressed_open[ext(c.path)](c.path, mode='a') | |||
| kwargs = dict(mode='at') | |||
| if sys.version_info[0] >= 3: | |||
There was a problem hiding this comment.
sys.version_info is a named tuple so you can do sys.version_info.major if you think thats cleaner
There was a problem hiding this comment.
alas, we have to support python 2.6, which doesn't implement sys.version_info as a namedtuple:
Python 2.6.9 |Continuum Analytics, Inc.| (unknown, Jan 10 2014, 13:33:57)
[GCC 4.2.1 (Apple Inc. build 5577)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import sys
>>> sys.version_info
(2, 6, 9, 'final', 0)
|
cool, going to give a go on windows and will merge if that's successful |
|
looks good on windows, merging |
cpcloud
added a commit
that referenced
this pull request
Apr 30, 2015
Fix writing compressed CSVs in python3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #187